[Docutils-users] Reverse order in rst-get-next-adornment

[Bernd Rellermeyer]

In rst.el, rst-get-next-adornment, the adornment hierarchyis searched
in reverse order if the reverse argument is nil, and in the normal order,
if the reverse argument is non-nil. I think that should be in the other way.

[Stefan Merten]

Hi Bernd!

Post by Bernd Rellermeyer
In rst.el, rst-get-next-adornment, the adornment hierarchyis searched
in reverse order if the reverse argument is nil, and in the normal order,
if the reverse argument is non-nil. I think that should be in the other way.

I agree that this part of the code is a bit smelly.

I am in a bigger process to refactor a lot of the code in `rst.el`. In
my (unpublished) version this parameter is called `down` which
probably better reflects the meaning.

Are there any practical consequences of your observation?


Grüße

Stefan

[Bernd Rellermeyer]

Hi Stefan,

there are no practical consequences. I often call rst-adjust and was wondering about the order.

Grüße
Bernd

Post by Stefan Merten
Hi Bernd!

Post by Bernd Rellermeyer
In rst.el, rst-get-next-adornment, the adornment hierarchyis searched
in reverse order if the reverse argument is nil, and in the normal order,
if the reverse argument is non-nil. I think that should be in the other way.

I agree that this part of the code is a bit smelly.
I am in a bigger process to refactor a lot of the code in `rst.el`. In
my (unpublished) version this parameter is called `down` which
probably better reflects the meaning.
Are there any practical consequences of your observation?
Grüße
Stefan